Implementation of 'local://' URI Scheme Support #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glesperance
changed the title
|
I agree this is useful. This line should also be updated to be the tuple "file", "local" to make sure we normalise URLs correctly. |
|
@martindurant: updated as suggested (e8c7253) |
|
@martindurant: updated failing tests |
|
filesystem_spec/fsspec/implementations/local.py Lines 211 to 218 in 89626e8 |
Thanks. Fixed it. |
|
@martindurant seems like I had the wrong syntax for the tuple assertion -- this was also fixed. Hopefully we're good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the local:// URI scheme. Although it's less ubiquitous than file://, this scheme is employed by key data engineering projects like Apache Spark and Ray.io for local file handling.
Including this support broadens our software's versatility and adaptability with these projects.
[1] Spark Example -- https://spark.apache.org/docs/latest/submitting-applications.html#advanced-dependency-management:~:text=local%3A%20%2D%20a%20URI%20starting%20with%20local%3A/%20is%20expected%20to%20exist%20as%20a%20local%20file%20on%20each%20worker%20node.%20This%20means%20that%20no%20network%20IO%20will%20be%20incurred%2C%20and%20works%20well%20for%20large%20files/JARs%20that%20are%20pushed%20to%20each%20worker%2C%20or%20shared%20via%20NFS%2C%20GlusterFS%2C%20etc.
[2] Ray.io example -- https://docs.ray.io/en/latest/data/api/doc/ray.data.Dataset.write_json.html#:~:text=jsonl%22)%0A%3E%3E%3E-,ds.write_json(%22local%3A///tmp/data%22),-Time%20complexity%3A%20O
[3] Genera Github Search for "local://" -- https://github.com/search?q=local://&type=code